-
Notifications
You must be signed in to change notification settings - Fork 594
Custom git pip packages not being installed #4364
Comments
@mcescalante I suspect the install is failing as you are using an SSH URI but Flynn does not trust the GitHub host key. I would suggest either using a HTTP URI:
or updating the
|
@lmars thanks for the reply! I saw your I'll give both of these a shot and see what happens and report back! |
Just made both changes, and am seeing the same exact errors in my application but no problems on deploy. Here are my deploy logs, showing no errors for install:
And
|
This is a duplicate of #3932. I believe that this is due to some assumptions that are made in the python buildpack about paths resulting in an invalid/incorrect path in an |
There is also this recently closed issue: heroku/heroku-buildpack-python#654. Try the latest buildpack with:
|
@titanous ah, yeah, that sounds correct. That issue slipped right by me, I suppose because I was looking for the wrong words in my issue searches before opening this 😄. @lmars great idea, I just gave that a shot but sadly I'm still getting the |
Well, since I've got stuck on this issue (thinking it is new pipenv issue), I'd like to add Flynn vs Heroku comparison, for the sake of completeness. (in my case used luminol package as editable dependency in Pipenv file) Flynn:
Heroku:
|
TLDR; quickfix: store script below into /bin/post_compile folder:
EXPLANATION: Python buildpack (https://github.com/heroku/heroku-buildpack-python/blob/v144/bin/compile) does this particular steps in following order: #L178: source "$BIN_DIR/steps/hooks/pre_compile" And the interesting parts here are in In the /eggpath-fix In the /eggpath-fix2 For some reason Heroku ends up after But Flynn ends up after Which you can see in previous comment.
so this should fix Extended version of the TLDR; script with debug
|
Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details. |
I've got a single dependency in my Pipfile that's being installed fine, from git (open source repo). It's a patched version of a library while I wait for a merge and release to PyPy:
requests-respectful = { git = 'git@github.com:mcescalante/requests-respectful.git', editable = 'true' }
When I deploy to flynn, everything deploys and releases successfully (no errors on Pipfile.lock install, Pipfile.lock is updated), but when I navigate to my application I'm met with the error:
No module named 'requests_respectful'
I further checked by running
flynn run bash
and thenpip list
. The package is missing from the returned list, indicating that it wasn't installed.I looked quickly over the issues in the upstream Heroku buildpack that's used for Python to see if there were outstanding issues, but this deploy actually works on Heroku itself fine, and there are no major outstanding issues apparent to me upstream that would cause this. You can find the Pipfile that I'm using in the repo: https://github.com/mcescalante/oh-fitbit-integration/blob/master/Pipfile
The text was updated successfully, but these errors were encountered: