Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for simultaneous TCP & HTTP Canary deployments in Istio #1612

Open
Raven6681 opened this issue Mar 8, 2024 · 2 comments
Open

Support for simultaneous TCP & HTTP Canary deployments in Istio #1612

Raven6681 opened this issue Mar 8, 2024 · 2 comments

Comments

@Raven6681
Copy link

Describe the feature

Currently (after implementing this: #1556), there are 2 options. Either use a HTTP port for the canary or a TCP port. Can't use both at the same time.

It would be great if flagger could support both at the same time (VirtualServices and DestinationRules in order to control traffic for both HTTP and TCP ports).

What problem are you trying to solve?

Create canaries for applications which expose 2 ports, one HTTP and one TCP.

@LiZhenCheng9527
Copy link
Contributor

Are you trying to publish using multiple ports? Perhaps you can refer to this document

@Raven6681
Copy link
Author

@LiZhenCheng9527 what you suggest (using portDiscovery: true) will include the discovered ports into the Service resources but it will not create a VirtualService with multiple ports (and protocols). Thus, The Canary will only handle the traffic of the one port defined in the spec.service
What I need is, the ability to declare 2 ports in the service with different protocols (http and tcp) thus creating a VirtualService with both spec.http and spec.tcp which will route the traffic to the respective DestinationRules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants