Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagger should support custom annotations on VirtualService/DestinationRule resources #1573

Open
rolandkool opened this issue Dec 20, 2023 · 0 comments

Comments

@rolandkool
Copy link

Describe the feature

We have a requirement to add custom annotations to VirtualService and DestinationRule resources. Our use case is that we add an annotation to indicate the resource needs to be synced to other clusters as we run Istio in multi-primary mode.

If we add a custom annotation through a mutating webhook, Flagger ends up in a loop where it cannot progress because the mutation triggers a reconcile and the VirtualService is reset to a weight of 100/0.

Proposed solution

We'd like to have a possibility for Flagger to either ignore custom annotations (through a parameter that can be specified when start flagger) or a way to specify them through the canary custom resource, similar as to what can be done for the Service to support External DNS annotations.

We don't have a preference for either solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant