Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for an update to HPA replicas resulting in a canary deployment #1563

Open
frankjkelly opened this issue Dec 6, 2023 · 1 comment

Comments

@frankjkelly
Copy link

Describe the feature

What problem are you trying to solve?

  • We are using Flagger for canary deployments.
  • We tried to update the min replicas of an existing deployment but when Flux deployed the change only updated the canary HPA and did not initiate a canary deploy via flagger. We had to make a slight adjust to the deployment like this https://github.com/fluxcd/flagger/blob/main/docs/gitbook/faq.md#how-to-retry-a-failed-release
    to initiate flagger making a canary deployment and at which point it copied the HPA over canary was deemed successful.

Proposed solution

Flagger could monitor not just the K8S deployment but associated HPA configuration (if any)

Any alternatives you've considered?

Is there another way to solve this problem that isn't as good a solution?
Great question - not sure.

@frankjkelly frankjkelly changed the title An update to HPA replicas results in a canary deployment Support for nn update to HPA replicas resulting in a canary deployment Dec 6, 2023
@frankjkelly frankjkelly changed the title Support for nn update to HPA replicas resulting in a canary deployment Support for an update to HPA replicas resulting in a canary deployment Dec 6, 2023
@frankjkelly
Copy link
Author

@stefanprodan @aryan9600 If you have time do you mind reviewing the above feature request and let me know if you think it is a reasonable ask or if you known of any alternatives. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant