Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update material _3_demo for ColorScheme updates #2289

Closed
Thanos-P opened this issue May 14, 2024 · 1 comment · Fixed by #2299
Closed

Update material _3_demo for ColorScheme updates #2289

Thanos-P opened this issue May 14, 2024 · 1 comment · Fixed by #2299
Assignees
@QuncCccccc

Comments

@Thanos-P
Copy link

It looks like the surfaceVariant and onSurfaceVariant colors have been removed from the demo colors. Furthermore, the onBackground has been erroneously replaced by onSurface.
image
@parlough parlough changed the title material _3_demo missing colors Update material _3_demo for new ColorScheme updates May 14, 2024
@parlough parlough changed the title Update material _3_demo for new ColorScheme updates Update material _3_demo for ColorScheme updates May 14, 2024
@parlough
Copy link
Member

Thanks for opening an issue! We just haven’t gotten around to updating the app for the latest ColorScheme changes.

@QuncCccccc QuncCccccc mentioned this issue May 21, 2024
Merged
5 tasks
parlough added a commit that referenced this issue May 22, 2024
@QuncCccccc @parlough
Update ColorScheme to show the newly added color roles (#2299)
649e0e4 
This PR is to fix #2289 and add newly added `ColorScheme` roles since
flutter/flutter#144273

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuncCccccc QuncCccccc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ColorScheme to show the newly added color roles flutter/samples
3 participants
@parlough @QuncCccccc @Thanos-P