FirebaseAuthPlugin: Error codes are not forwarded to Dart

[escamoteur]

Hi,

I just found out that if an error happens on the FirebaseAuth side like "email already used" I will only get an

      throw new PlatformException(code: errorCode, message: errorMessage, details: errorDetails);

with errorCode = "exception" and an error message that isn't localized which isn't really helpful.

Looking at the Java side of the plugin made it obvious

 private class SignInCompleteListener implements OnCompleteListener<AuthResult> {
    private final Result result;

    SignInCompleteListener(Result result) {
      this.result = result;
    }

    @Override
    public void onComplete(@NonNull Task<AuthResult> task) {
      if (!task.isSuccessful()) {
        Exception e = task.getException();
        result.error(ERROR_REASON_EXCEPTION, e.getMessage(), null);
      } else {
        FirebaseUser user = task.getResult().getUser();
        ImmutableMap<String, Object> userMap = mapFromUser(user);
        result.success(userMap);
      }
    }
  }

This should actually be a [FirebaseAuthException](https://firebase.google.com/docs/reference/android/com/google/firebase/auth/FirebaseAuthException)

which has a `GetErrorCode` method. Please change that so that Apps can react on error conditions with their own texts.

[timsneath]

Good catch - thanks, @escamoteur. Adding @collinjackson.

[zoechi]

Similar to #13027

[escamoteur]

Difference is that for FirebaseAuth you get an exception on the Dart side but no error code

[twpochuan]

After removing the 'google_sign_in' from dependencies, the error codes came back.
It seems something goes wrong or override the exception when 'google_sign_in' is added into the dependencies.

EDIT:
I got the error codes back on ios, but there is still no error codes on Android...

Update:
I tried to trace the code and decoded the raw response from firebase auth:

without 'google_sign_in':

iOS: flutter: \^G�Error 17008\^G\^RFIRAuthErrorDomain\^G%The email address is badly fo<…>
Android: I/flutter ( 1450): �	exception�%The email address is badly formatted.

with 'google_sign_in':

iOS: flutter: \^G\^Nsign_in_failed\^G\^RFIRAuthErrorDomain\^G%The email address is badly <…>
Android: I/flutter ( 4105): �	exception�%The email address is badly formatted.

[eseidelGoogle]

This looks like a quick fix. @bparrishMines or @kroikie may be interested.

[MateusPalomo]

If you encounter something like below,
this is because there is an extra spacing at the end of your email. ==>
I/flutter (14294): Error PlatformException(exception, The email address is badly formatted., null)

Try delete extra spacing,

[kroikie]

@escamoteur

This issue has been moved to firebase/flutterfire#802. Any further collaboration will be done there.

[reinaldobrazpereira]

Obrigado MateusPalomo.
Era um espaço extra mesmo, e fiquei algum tempo em cima deste erro.
Abraço.

[VisheshAtWork]

Same issue. Any work around ?

[KristianBalaj]

Still an issue.

[folivi]

Hi all,
Has this been fixed? Tried calling createUserWithEmailAndPassword inside a try catch block both handling platformException and FirebaseAuthException but the app litterally crashes when an on the email-exists error

[escamoteur]

please report here: firebase/flutterfire#802

[escamoteur]

@kroikie unfortunately the other thread got locked which I find pretty strange if this isn't fixed yet. I am pretty sure there was a PR with this fix from @slightfoot a long time ago

[slightfoot]

I did fix this. But the FlutterFire migration work changed the error codes to the web sdk ones. Either way it could be a platform specific regression. @Salakar would know.

[Salakar]

cc @Ehesp

[muhammadsqln]

How is this still fixed

[escamoteur]

@muhammadsqln does it still not work?

[EriKWDev]

This is still a problem.. I'm following the very basic usage tutorial code on https://firebase.flutter.dev/docs/auth/usage but PlatformException is thrown and not catched in debug mode on VSCode which makes debugging basically unbearable. I'm not using google_sign_in

[escamoteur]

What do you mean by that VS code isn't catching the PlatformException? did you enable break on all exceptions?

[EriKWDev]

Sorry, I meant the opposite xP I don't want VSCode to stop on PlatformException but it goes ahead and does it anyway... I'm running the code

UserCredential userCredential;

try {
  userCredential = await FirebaseAuth.instance.signInWithEmailAndPassword(email: email, password: password);
} on FirebaseAuthException catch (e) {
  if (e.code == 'user-not-found') {
    print('No user found for that email.');
  } else if (e.code == 'wrong-password') {
    print('Wrong password provided for that user.');
  }
} on PlatformException catch(e) {
  print(e);
}

on an Android emulator from VSCode debug mode. I have "Break on All Exceptions" turned off, but when the code is called the debugger stops anyway on PlatformException from message_codecs.dart

The error code is there, but something doesn't catch it..

[Ehesp]

Please create new issues on the FlutterFire repo so maintainers have visibility. This will not be seen/addressed here.

[escamoteur]

if you hit continue it does not get caught int your 'on PlatformException'?

[EriKWDev]

Please create new issues on the FlutterFire repo so maintainers have visibility. This will not be seen/addressed here.

Will do!

[EriKWDev]

if you hit continue it does not get caught int your 'on PlatformException'?

No, it doesn't.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.