Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual roll camera dependency #148426

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

goderbauer
Copy link
Member

Supersedes #148245

@goderbauer
Copy link
Member Author

Looks like just removing that extra dependency is not enough. Now there are other gradle errors.

@stuartmorgan
Copy link
Contributor

Buried in the output is:

┌─ Flutter Fix ───────────────────────────────────────────────────────────────────────────────┐
│ You need to update the lockfile, or disable Gradle dependency locking.                      │
│ To regenerate the lockfiles run: `./gradlew :generateLockfiles` in                          │
│ /b/s/w/ir/x/w/flutter/dev/integration_tests/gradle_deprecated_settings/android/build.gradle │
│ To remove dependency locking, remove the `dependencyLocking` from                           │
│ /b/s/w/ir/x/w/flutter/dev/integration_tests/gradle_deprecated_settings/android/build.gradle │
└─────────────────────────────────────────────────────────────────────────────────────────────┘

@goderbauer
Copy link
Member Author

goderbauer commented May 15, 2024

Thanks, totally missed that in the output. The command fails, though:

% ./gradlew :generateLockfiles

Welcome to Gradle 8.3!

Here are the highlights of this release:
 - Faster Java compilation
 - Reduced memory usage
 - Support for running on Java 20

For more details see https://docs.gradle.org/8.3/release-notes.html

Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

> Configure project :app
You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/go/flutter-gradle-plugin-apply

w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:107:40: Variable 'agpVersion' initializer is redundant
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:108:40: Variable 'kgpVersion' initializer is redundant
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:143:28: Parameter 'project' is never used
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:152:40: Variable 'agpVersion' initializer is redundant
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:167:55: 'Version' is deprecated. Deprecated in Java
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:195:56: Unnecessary non-null assertion (!!) on a non-null receiver of type Any
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:344:28: The corresponding parameter in the supertype 'Comparable' is named 'other'. This may cause problems when calling this function with named arguments.
Starting a Gradle Daemon, 1 busy and 1 incompatible Daemons could not be reused, use --status for details

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not open proj generic class cache for build file '/Users/goderbauer/dev/flutter/dev/integration_tests/gradle_deprecated_settings/android/build.gradle' (/Users/goderbauer/.gradle/caches/8.3/scripts/c192y7qa3j8v1de05e2zs4p7).
   > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 66

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s

FAILURE: Build failed with an exception.

* Where:
Script '/Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 222

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not create task ':generateLockfiles'.
   > Process 'command '/Users/goderbauer/dev/flutter/dev/integration_tests/gradle_deprecated_settings/android/gradlew'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 18s

@stuartmorgan
Copy link
Contributor

Unsupported class file major version 66

IIRC that means your Java version isn't in the support range of your Gradle version. This isn't my area of expertise, but it looks from a skim of search results like this mean you are using Java 22, and the Gradle output sounds like it's only supporting 20 at that version.

@reidbaker may have suggestions on how to handle this (other than by installing an old version of Java)?

@goderbauer
Copy link
Member Author

For future archeologists:

@gmackall helped me out and instructed me to set my JAVA_HOME to the java version that shipped with the engine:

export JAVA_HOME=/Users/goderbauer/dev/engine/src/third_party/java/openjdk/Contents/Home

With that, the ./gradlew :generateLockfiles run succeeded in regenerating the lock files. Now 🤞 that everything will pass on CI as well.

Thanks a ton for everyone's help with this one!

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@goderbauer
Copy link
Member Author

Note to self: Remember to close #148245 when this is submitted to restart auto-roller.

@auto-submit auto-submit bot merged commit 40b5bc3 into flutter:master May 20, 2024
139 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2024
@goderbauer goderbauer deleted the manualCameraBump branch May 21, 2024 16:07
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 21, 2024
flutter/flutter@02a6c91...d02292d

2024-05-21 ian@hixie.ch Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 magder@google.com Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 rmolivares@renzo-olivares.dev SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 katelovett@google.com [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 goderbauer@google.com Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 katelovett@google.com [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 louisehsu@google.com Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 jason-simmons@users.noreply.github.com Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 andrewrkolos@gmail.com log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 katelovett@google.com [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 sokolovskyi.konstantin@gmail.com Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 102401667+Dimilkalathiya@users.noreply.github.com fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 nate.w5687@gmail.com Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 nate.w5687@gmail.com Reland "`if` chains � `switch` expressions" (flutter/flutter#148634)
2024-05-20 gspencergoog@users.noreply.github.com Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 zanderso@users.noreply.github.com Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 22, 2024
…-coder-xu/flutter into fix/slider_text_null_error

* 'fix/slider_text_null_error' of https://github.com/hello-coder-xu/flutter: (65 commits)
  Change implementation method
  fix slider text null error
  Make FileSystem dependency explicit througout (more). (flutter#148095)
  Remove add-to-app bitcode warning (flutter#148587)
  SelectionArea's selection should not be cleared on loss of window focus (flutter#148067)
  [wiki migration] Engine team pages (flutter#148696)
  Manual roll camera dependency (flutter#148426)
  [wiki migration] Framework team pages (flutter#148721)
  Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter#148722)
  Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter#148715)
  Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter#148714)
  Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter#148580)
  Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter#148700)
  Remove the no-shuffle tag on the flutter_tools create_test suite (flutter#148688)
  log incoming vm service messages in `FlutterVMService::runInView` (flutter#148596)
  Add tests for shared_app_data.#.dart API examples. (flutter#147830)
  Add tests for logical_key_set.0.dart API example. (flutter#147735)
  [wiki migration] Ecosystem team pages (flutter#148589)
  Fix painting API examples tests directories structure. (flutter#148177)
  fixes `CupertinoModalPopupRoute` (flutter#147823)
  ...
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…r#6778)

flutter/flutter@02a6c91...d02292d

2024-05-21 ian@hixie.ch Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 magder@google.com Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 rmolivares@renzo-olivares.dev SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 katelovett@google.com [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 goderbauer@google.com Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 katelovett@google.com [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 louisehsu@google.com Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 jason-simmons@users.noreply.github.com Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 andrewrkolos@gmail.com log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 katelovett@google.com [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 sokolovskyi.konstantin@gmail.com Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 102401667+Dimilkalathiya@users.noreply.github.com fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 nate.w5687@gmail.com Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 nate.w5687@gmail.com Reland "`if` chains � `switch` expressions" (flutter/flutter#148634)
2024-05-20 gspencergoog@users.noreply.github.com Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 zanderso@users.noreply.github.com Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants