Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakes in GaussianBlurMipMapImageFilter and GaussianBlurMipMapNestedLayer #148320

Open
zanderso opened this issue May 14, 2024 · 7 comments
Open
Labels
e: impeller Impeller rendering backend issues and features requests P1 High-priority issues at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@zanderso
Copy link
Member

zanderso commented May 14, 2024

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8747956743136702833/+/u/test:_Host_Tests_for_host_debug/stdout

Both failed with:

[FATAL:flutter/impeller/base/validation.cc(57)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create render pipeline for TextureFill Pipeline :Compiler encountered an internal error
@zanderso zanderso added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels May 14, 2024
@zanderso
Copy link
Member Author

Seeing on some other tests as well https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8747865981990983953/+/u/test:_Host_Tests_for_host_debug_unopt/stdout.

Are these unit tests running in parallel? Wondering if there are races.

@chinmaygarde
Copy link
Member

We saw these types of issues with the Skia backend at runtime in #68649 (comment) and that issue was closed after it stopped happening after a while. There was no resolution. There was some talk about this being bot specific but I have not been able to confirm this.

@jason-simmons
Copy link
Member

I was unable to reproduce this locally.

Both of the failures above were on build873-m9. That bot does seem to have an unusual number of these failures in its history (https://chromium-swarm.appspot.com/bot?id=build873-m9)

@jonahwilliams
Copy link
Member

Bad bot, but we don't currently know how to take it out of the pool

@jonahwilliams jonahwilliams added P1 High-priority issues at the top of the work list triaged-engine Triaged by Engine team labels May 20, 2024
@zanderso
Copy link
Member Author

I found out how to remove a bot from the pool.

  1. git clone https://chrome-internal.googlesource.com/infradata/config
  2. Edit https://chrome-internal.googlesource.com/infradata/config/+/refs/heads/main/configs/chromium-swarm/starlark/bots/flutter.star
  3. Run ./main.star at the root of that repo.
  4. Upload the change with git cl upload.

I've done that in https://chrome-internal-review.googlesource.com/c/infradata/config/+/7315539, but I'd like to know that we're still seeing this failure only on the one bot before we land it. @jason-simmons do you know if that's still what we're seeing?

@jason-simmons
Copy link
Member

All of the failures that I've noticed were on that bot. I don't know how to check whether any similar failures have shown up on any other bots.

@zanderso
Copy link
Member Author

The bot was re-imaged as a first step before removing it from service. We'll have to continue monitoring for continued failures on the same bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: impeller Impeller rendering backend issues and features requests P1 High-priority issues at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

4 participants