Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing usages of embed=true query parameter for DevTools screens to embedMode=one #7403

Open
kenzieschmoll opened this issue May 7, 2024 · 0 comments · May be fixed by #7417
Open
Assignees
Labels
devtools-integration Related to the integration with Dart DevTools

Comments

@kenzieschmoll
Copy link
Member

As of flutter/devtools#7710, which was rolled into the Dart SDK in https://dart-review.googlesource.com/c/sdk/+/365620, DevTools expects a new format for setting embedded mode. We will still need to use the legacy query parameter for Dart SDK versions before https://dart-review.googlesource.com/c/sdk/+/365620.

There are now two embedded modes that can be set through a query parameter: embedMode=one (for embedding a single screen, which is the current behavior) or embedMode=many (for embedding many screens, which is newly supported behavior added for #7195).

The change was made to be backwards compatible with embed=true, but we should migrate to the new format so that we can remove the legacy handlers.

@helin24 helin24 linked a pull request May 9, 2024 that will close this issue
@kenzieschmoll kenzieschmoll added the devtools-integration Related to the integration with Dart DevTools label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools-integration Related to the integration with Dart DevTools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants