Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program crashes immediately after scanning. #2

Open
UnoNYC opened this issue Oct 20, 2022 · 10 comments
Open

Program crashes immediately after scanning. #2

UnoNYC opened this issue Oct 20, 2022 · 10 comments

Comments

@UnoNYC
Copy link

UnoNYC commented Oct 20, 2022

The program crashes immediately after completing the scan and without error.

My OS is W10 22H2.

@richpeck
Copy link
Contributor

Good morning, thank you very much for the comment!!

To be clear - the behaviour you're reporting is that the system completed a scan, showed you the number of errors it found and, upon clicking "next", it crashed?

Rich

@UnoNYC
Copy link
Author

UnoNYC commented Oct 22, 2022

Hi, thank you for the response, and I apologize for the delay in mine. To answer your question, it scans very quickly and then once it gets to 100% it closes itself as if nothing happened.

There isnt any indication that the scan was done, let alone completed successfully or that it found anything.

Would you like me to record a video of what happens?

@richpeck
Copy link
Contributor

Hi there, no problem on your time to reply!

Thank you for the information. A video would, indeed, be very helpful. I just need to see where it's failing to see if I can pinpoint the code that's likely raising an exception.

Rich

@UnoNYC
Copy link
Author

UnoNYC commented Oct 23, 2022

Hi I just recorded this video.. here is the Dropbox link..

https://www.dropbox.com/s/30hyvgamxiydkcx/20221023_153228.mp4?dl=0

The software version is 2.0.0.0 I couldnt find the 2.0.0.3 version mentioned on your site and I couldnt find the msi installer version, so this one just runs out of a folder..

Also, the only reason it shows a last scan date under the button was because I unchecked everything and then ran a scan just to see what would happen.

@richpeck
Copy link
Contributor

Hi, thank you so much for the video!!!

Sorry for the delay in response. I'm on a tight deadline (for Friday), so have been neck deep in code today.

I've had a look at the video and, considering you've said that it managed to scan when there was no option selected, I would presume the issue lies in how it's cycling through those "recent documents" options.

I will have a look at the app code tomorrow and see if I can find the part that's causing the crash for you. It may be something like not having Visual C++ Redist x86 installed.

--

Regarding the 2.0.0.3 version, that was mainly because we were trying to get it listed in the Microsoft store (we were invited to submit "desktop" apps in a trial). The codebase that's available now is the 2.0.0.0 version with some tweaks to get it working in Visual Studio 2015+. 2.0.0.0 was production when we were selling it in 2010/2011.

I have been working on a vastly updated version (2.1.0.0) which is entirely based on vectorized WPF. This means it's entirely responsive and I've managed to fix a lot of the bugs + problems from the older version.

Having said this, the backend engine (c++ DLL) is the same between all versions, so I will check to see if there is anything that stands out there. If I cannot find anything, I will add an exception handler into the scanner for you so we can debug what's going on.

I'll give you an update tomorrow when I've had a chance to look over it.

@UnoNYC
Copy link
Author

UnoNYC commented Oct 25, 2022

Hey its no problem, I am just glad that I could help.. that part about MS wanting you to upload as a demo isn't surprising.. I have found that a lot of apps that would normally be free due to it being open source or similar are paid on W10s app store.. and even then, they arent the original, just based on the GNU versions.

This, in addition to me not needing "apps" on my laptop like I have on my phone and tablet and privacy are the reasons why I have decided to go with open source and away from built-in or paid programs as much as possible. I've been burned before.. and the increase in money spent did not translate into better software.. only eventual abandonment of said project.

Anyway thanks again for the replies and I look forward to your next release.

@richpeck
Copy link
Contributor

Hey its no problem, I am just glad that I could help.. that part about MS wanting you to upload as a demo isn't surprising.. I have found that a lot of apps that would normally be free due to it being open source or similar are paid on W10s app store.. and even then, they arent the original, just based on the GNU versions.

That doesn't surprise me. When I mentioned the Microsoft process, I meant that we would publish the application for free.

The big problem that's beset the Microsoft Store has been that they've tried to copy Apple's, which included the highly restrictive permissions. This meant that any apps published in the store could not interfere with the system at a core level (for example, the registry or system files).

I discovered MS were allowing certain publishers to submit 'desktop' apps in a limited trial. I applied us to the trial and tried to submit our app. Unfortunately, the submission process was so convoluted and complex that I ended up shelving it until the 2.1 version is done.

This, in addition to me not needing "apps" on my laptop like I have on my phone and tablet and privacy are the reasons why I have decided to go with open source and away from built-in or paid programs as much as possible. I've been burned before.. and the increase in money spent did not translate into better software.. only eventual abandonment of said project.

It's a difficult one because the developer needs money to keep the lights on, but when you bring money into the equation, you typically find people lose interest and only do what's required to get paid.

The most valuable projects are ones driven by a core passion. Ironically, they often tend to be open source because of the way in which they're able to foster a community as a result.

We decided to open source this product because it was just sitting on a USB drive (we don't sell it anymore). So you're welcome to use it as much as you wish.

--

I will take a look into the code today and see if we can figure out what's going on with your system for you.

@richpeck
Copy link
Contributor

Hi there, hope you're well.

I have added a number of exception handler callbacks into the scanning script.

Due to the sudden closure of the app on your system (IE no error messages), I have had to make some educated guesses as to what might be causing the error to show. This means that I may not have places the callbacks in the correct place in the script.

I have attached a ZIP with the latest build (which includes these error handlers).

If you run the EXE file & it crashes, a .txt file should be created in the same directory as the application. This file should contain a stack trace of the error, which will allow me to make appropriate adjustments to the code in order to get it working properly.

If no txt file appears, it means that my exception handlers are not catching the error, and I'll need to add more - which isn't a problem by any degree, I would just need to know from your end as I have no control over how it's running on your system.

If you could run it and let me know what happens, that would be deeply appreciated!

Rich
FLCleaner-ExceptionHandler.zip

@UnoNYC
Copy link
Author

UnoNYC commented Oct 31, 2022

Hi, I just got your email, I apologize for the delay in my response, I have been crazy busy, and I'm in the midst of a cross-country move.. but I will check it out and report back!

@UnoNYC
Copy link
Author

UnoNYC commented Nov 3, 2022

Hi there, hope you're well.

I have added a number of exception handler callbacks into the scanning script.

Due to the sudden closure of the app on your system (IE no error messages), I have had to make some educated guesses as to what might be causing the error to show. This means that I may not have places the callbacks in the correct place in the script.

I have attached a ZIP with the latest build (which includes these error handlers).

If you run the EXE file & it crashes, a .txt file should be created in the same directory as the application. This file should contain a stack trace of the error, which will allow me to make appropriate adjustments to the code in order to get it working properly.

If no txt file appears, it means that my exception handlers are not catching the error, and I'll need to add more - which isn't a problem by any degree, I would just need to know from your end as I have no control over how it's running on your system.

If you could run it and let me know what happens, that would be deeply appreciated!

Rich
FLCleaner-ExceptionHandler.zip

Hi, I just tried this out, it crashed immediately after the scan and there was no text file left behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants