Assertions for StatusCode on HttpResponseMessage

[mu88]

I'm using Fluent Assertions for the integration / E2E tests of my web API as well. So I have a couple of assertions which look like response.StatusCode.Should().Be(HttpStatusCode.Ok).

What do you think about some assertions for StatusCode on HttpResponseMessage like:

• BeSuccessStatusCode()
• BeFailedStatusCode()
• BeStatusCode(HttpStatusCode expectedStatusCode)

If you like the idea, I'd love to provide a PR.

[dennisdoomen]

It depends. If it requires FA to take additional dependencies. But maybe it would be a better fit for https://github.com/fluentassertions/fluentassertions.aspnetcore.mvc cc @kevinkuszyk

[faddiv]

fluentassertions.aspnetcore.mvc deals specifically with the asp.net core classes like action result so it depends on these libs. This seems more like a separate thing.

[mu88]

Meaning that you would see the proposed assertions for StatusCode not within FluentAssertions.AspNetCore.MVC?

[faddiv]

I see two problems with it:
HttpResponseMessage is part of the System.Net.Http, which is a core assembly. FluentAssertions.AspNetCore.MVC depends on Microsoft.AspNetCore.Mvc.Core and therefore it is an unnecessary dependency in this case.
Also, I think this is a different kind of testing than which the FluentAssertions.AspNetCore.MVC aims for.
What is your opinion @dennisdoomen? Do you think this is still ok?

[dennisdoomen]

Yeah, you're right. So I think it's fine to add them to our core library after all.

[mu88]

Okay guys, thank you for the positive discussion :) so I will provide a PR with my existing assertions.