Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: "Fiber#storage has borked keys and is being monkey-patched." #4488

Open
daipom opened this issue May 7, 2024 · 1 comment
Open

Warning: "Fiber#storage has borked keys and is being monkey-patched." #4488

daipom opened this issue May 7, 2024 · 1 comment
Labels
bug

Comments

@daipom
Copy link
Contributor

daipom commented May 7, 2024 •
edited

Describe the bug

This message is shown when executing Fluentd or the tests.

Fiber#storage has borked keys and is being monkey-patched.

fiber-storage gem outputs this message.
It is one of the dependants of console gem.

I don't know when it started to be shown.
I found the cause.
console gem v1.25 specifies the min ver of fiber-local to v1.1.0.
And, fiber-local v1.1.0 somehow causes fiber-storage to output the warning.

I can't find GitHub repository of fiber-storage.
But I can confirm the local gem file, and the message is from fiber-storage.

To Reproduce

$ git clone git@github.com:fluent/fluentd.git
$ cd fluentd
$ bundle
$ bundle exec fluentd --version
Fiber#storage has borked keys and is being monkey-patched.
fluentd 1.17.0

Expected behavior

$ fluentd --version
fluentd 1.17.0

Your Environment

- Fluentd version: 1.17.0
- TD Agent version:
- Operating system: Ubuntu 20.04.6 LTS (Focal Fossa)
- Kernel version: 5.15.0-105-generic

Your Configuration

None

Your Error Log

None

Additional context

No response
This was referenced May 7, 2024
Closed
Open
daipom added a commit to daipom/fluentd that referenced this issue May 13, 2024
@daipom
log/console_adapter: support console gem v1.25
9e9c5f2 
`Console::Terminal::Logger` class path has changed in `console`
gem v1.25:

socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12

For the v1.25, there is another issue about a warning(fluent#4488):

    Fiber#storage has borked keys and is being monkey-patched.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom mentioned this issue May 13, 2024
Merged
daipom added a commit to daipom/fluentd that referenced this issue May 13, 2024
@daipom
log/console_adapter: support console gem v1.25
daa6c76 
`Console::Terminal::Logger` class path has changed in `console`
gem v1.25:

socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12

Note: We can't stop considering the older versions because v1.25
requires Ruby v3.1 or older. 

For the v1.25, there is another issue about a warning(fluent#4488):

    Fiber#storage has borked keys and is being monkey-patched.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom
Copy link
Contributor Author

daipom commented May 13, 2024

I have made an issue for fiber-local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daipom