Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change layout for flox show output #1441

Closed
mkenigs opened this issue May 9, 2024 · 3 comments
Closed

Change layout for flox show output #1441

mkenigs opened this issue May 9, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers product Tickets relevant to the flox product team and/or functional requirements team-cli Tickets relevant to the flox CLI team
Milestone

Comments

@mkenigs
Copy link
Contributor

mkenigs commented May 9, 2024

Judging from output in the spec, the output for flox show was designed to handle different pkg_paths:

nodejs - A yadaa ydaa thingy
  nodejs-14_x    nodejs@14.21.3
  nodejs-16_x    nodejs@16.20.1
  nodejs-18_x    nodejs@18.16.1
  nodejs_14      nodejs@14.21.3
  nodejs_16      nodejs@16.20.1
  nodejs_18      nodejs@18.16.1
  nodejs_20      nodejs@20.4.0
  nodejs_latest  nodejs@20.4.0

show is now restricted to a single pkg_path, so we should:

  • make --all the default/completely drop it as an option
  • change the layout to be:
bash - GNU Bourne-Again Shell, the de facto standard shell on Linux
    bash@5.2p26
    bash@5.2-p21

We can make this change for both catalog and pkgdb code paths.

@zmitchell zmitchell added good first issue Good for newcomers team-cli Tickets relevant to the flox CLI team labels May 9, 2024
@mkenigs mkenigs added this to the Catalog 2 milestone May 9, 2024
@dcarley dcarley self-assigned this May 10, 2024
@ghudgins ghudgins added the product Tickets relevant to the flox product team and/or functional requirements label May 10, 2024
@ghudgins
Copy link
Contributor

@jennymahmoudi this LGTM but wanted to confirm with you too

@jennymahmoudi
Copy link
Contributor

Is this because the values in the left column would always be the same now? If so 👍 👍 👍

@ghudgins
Copy link
Contributor

@jennymahmoudi yes. show was designed to be fuzzy originally I think and now it's not. so you'll only ever get a single package

verified this on the branch!

@dcarley dcarley closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers product Tickets relevant to the flox product team and/or functional requirements team-cli Tickets relevant to the flox CLI team
Projects
None yet
Development

No branches or pull requests

5 participants