New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set catalog feature flag for integration tests (pkgdb) #1436

Open

mkenigs opened this issue May 9, 2024 · 1 comment

Labels

team-cli

Milestone

Contributor

mkenigs commented May 9, 2024

Assess any behaviors in groups.bats, lockfile.bats, and search.bats that are relevant to the catalog. Ensure they are tested in either the CLI or serverside that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
If anything that isn't minor breaks, create followup tickets

The text was updated successfully, but these errors were encountered:

mkenigs added this to the Catalog 3 milestone

mkenigs added the team-cli label

Contributor Author

mkenigs commented May 20, 2024 •

edited

There should be serverside tests for:
groups.bats

packages in different groups can resolve to different pages
impossible constraints in the same group fails

search.bats

exact version works
semver tests:
- range works
- partial semvers work (18, 18.18)
- * works (18.*)
prefer-pre-releases works
nodePackages gets searched

(testing of unfree and broken filtering are deferred until we implement that)

There should be a CLI test for:
lockfile.bats

the per package system field is handled correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment