New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set catalog feature flag for integration tests (upgrade) #1435

Open

mkenigs opened this issue May 9, 2024 · 1 comment

Assignees

Labels

team-cli

Milestone

Contributor

mkenigs commented May 9, 2024

Copy any tests in upgrade.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK=/dev/null for all other tests in the file
If anything that isn't minor breaks, skip copied tests and create followup tickets

The text was updated successfully, but these errors were encountered:

mkenigs added this to the Catalog 3 milestone

mkenigs added the team-cli label

Contributor

zmitchell commented May 20, 2024 •

edited

These tests likely need to be completely rewritten, but most of them can be made into unit tests.

Notes:

We recently discussed what it means to upgrade by install id. I don't know where that decision was written down or what the final outcome was, but it needs to be encoded as a test.
"'flox upgrade' upgrades with catalog" should be separate tests

zmitchell self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment