New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set catalog feature flag for integration tests (show) #1433

Open

mkenigs opened this issue May 9, 2024 · 1 comment

Labels

team-cli

Milestone

Contributor

mkenigs commented May 9, 2024

Do some combination of:

Copy tests in show.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
Port those tests to unit tests run with the catalog feature set

In any case:

Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK=/dev/null for all other tests in the file
If anything that isn't minor breaks, skip copied tests and create followup tickets

The text was updated successfully, but these errors were encountered:

mkenigs added this to the Catalog 3 milestone

mkenigs added the team-cli label

Contributor Author

mkenigs commented May 21, 2024 •

edited

The following need to be copied and made to work with the catalog:

'flox show' accepts search output without separator
'flox show' - hello
'flox show' - hello --all

This one could probably be a unit test, but I'm not sure whether it's worth porting just one test:

'flox show' - python310Packages.flask

These are ensuring things get scraped so should be present serverside:

'flox show' - python27Full
'flox show' - python27Full --all
'flox show' - rubyPackages.rails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment