Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set catalog feature flag for integration tests (pull) #1430

Open
mkenigs opened this issue May 9, 2024 · 0 comments
Open

set catalog feature flag for integration tests (pull) #1430

mkenigs opened this issue May 9, 2024 · 0 comments
Labels
team-cli Tickets relevant to the flox CLI team
Milestone
Catalog 3

Comments

@mkenigs
Copy link
Contributor

mkenigs commented May 9, 2024 •
edited by dcarley

  • Copy any tests in pull.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
  • Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK="$TESTS_DIR/catalog_responses/empty_responses.json" for any other tests in the files to assert that they don't depend on the catalog
  • If anything that isn't minor breaks, skip copied tests and create followup tickets
@mkenigs mkenigs added this to the Catalog 3 milestone May 9, 2024
@mkenigs mkenigs added the team-cli Tickets relevant to the flox CLI team label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-cli Tickets relevant to the flox CLI team
Projects
None yet
Milestone
Catalog 3
Development

No branches or pull requests
1 participant
@mkenigs