Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set catalog feature flag for integration tests (init) #1424

Open
mkenigs opened this issue May 8, 2024 · 2 comments
Open

set catalog feature flag for integration tests (init) #1424

mkenigs opened this issue May 8, 2024 · 2 comments
Labels
team-cli Tickets relevant to the flox CLI team
Milestone

Comments

@mkenigs
Copy link
Contributor

mkenigs commented May 8, 2024

  • Copy any tests in init.bats, python.bats, node.bats, and go.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
  • Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK="$TESTS_DIR/catalog_responses/empty_responses.json" for any other tests in the files to assert that they don't depend on the catalog
  • If anything that isn't minor breaks, skip copied tests and create followup tickets
@mkenigs mkenigs added the team-cli Tickets relevant to the flox CLI team label May 8, 2024
@mkenigs mkenigs added this to the Catalog 3 milestone May 8, 2024
@mkenigs mkenigs added team-cli Tickets relevant to the flox CLI team and removed team-cli Tickets relevant to the flox CLI team labels May 9, 2024
@dcarley
Copy link
Contributor

dcarley commented May 22, 2024

Notes from refinement:

  • There is one Python test in init.bats that should be moved to python.bats
  • The rest of init.bats shouldn't depend on the catalog.
  • All of the language auto-setup tests auto-install packages from the catalog

@mkenigs
Copy link
Contributor Author

mkenigs commented May 22, 2024

* There is one Python test in `init.bats` that should be moved to `python.bats`

The reason that one is in init.bats is because it's checking init and particularly FLOX_ENV_CACHE works for different types of environments (path, managed, remote). All of the language specific functional tests only use path environments. I'm not sure that's the most useful distinction but that's the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-cli Tickets relevant to the flox CLI team
Projects
None yet
Development

No branches or pull requests

2 participants