Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set catalog feature flag for integration tests (environment-managed) #1422

Open
mkenigs opened this issue May 8, 2024 · 1 comment
Open
Labels
team-cli Tickets relevant to the flox CLI team
Milestone

Comments

@mkenigs
Copy link
Contributor

mkenigs commented May 8, 2024

  • Copy any tests in environment-managed.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
  • Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK=/dev/null for all other tests in the file
  • If anything that isn't minor breaks, skip copied tests and create followup tickets
@mkenigs mkenigs added the team-cli Tickets relevant to the flox CLI team label May 8, 2024
@mkenigs mkenigs added this to the Catalog 3 milestone May 8, 2024
@mkenigs mkenigs added team-cli Tickets relevant to the flox CLI team and removed team-cli Tickets relevant to the flox CLI team labels May 9, 2024
@mkenigs
Copy link
Contributor Author

mkenigs commented May 21, 2024

All of the following tests need to be modified to work with the catalog because they're all performing installs. It would probably be more efficient to not have to perform a full install for every test, but most of the tests are testing behavior across multiple commands (push and pull) so I'm not sure if there's an obvious way to improve that

  • m1: install a package to a managed environment
  • m2: uninstall a package from a managed environment
  • m3: edit a package from a managed environment
  • m4: pushed environment can be pulled
  • m5: updated environment can be pulled
  • m7: remote can not be pulled into diverged environment
  • m8: remote can be force pulled into diverged environment
  • m11: uses fresh branch after delete
  • sanity check upgrade works for managed environments (see catalog.bats for inspiration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-cli Tickets relevant to the flox CLI team
Projects
None yet
Development

No branches or pull requests

1 participant