Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set catalog feature flag for integration tests (containerize) #1421

Open
mkenigs opened this issue May 8, 2024 · 2 comments
Open

set catalog feature flag for integration tests (containerize) #1421

mkenigs opened this issue May 8, 2024 · 2 comments
Labels
team-cli Tickets relevant to the flox CLI team
Milestone

Comments

@mkenigs
Copy link
Contributor

mkenigs commented May 8, 2024

  • Copy the podman/docker tests in containerize.bats and run them with the catalog feature flag set. Make any small changes required to get them passing
  • Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK=/dev/null for all other containerize tests since they shouldn't be impacted by the catalog
  • If anything that isn't minor breaks, skip copied tests and create followup tickets
@mkenigs mkenigs added the team-cli Tickets relevant to the flox CLI team label May 8, 2024
@mkenigs mkenigs added this to the Catalog 3 milestone May 8, 2024
@mkenigs mkenigs added team-cli Tickets relevant to the flox CLI team and removed team-cli Tickets relevant to the flox CLI team labels May 9, 2024
@zmitchell
Copy link
Contributor

  • These probably need to stay integration tests
  • From a cursory glance I don't think catalog server is involved at all

@mkenigs
Copy link
Contributor Author

mkenigs commented May 21, 2024

Need to add 1 mock hello response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-cli Tickets relevant to the flox CLI team
Projects
None yet
Development

No branches or pull requests

2 participants