New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set catalog feature flag for integration tests (list) #1420

Open

ghudgins opened this issue May 8, 2024 · 1 comment

Labels

team-cli

Milestone

Contributor

ghudgins commented May 8, 2024 •

edited by mkenigs

Either:

Copy any tests in list.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing

Or:

Port those tests to unit tests run with the catalog feature set

In both cases:

Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK=/dev/null for all other tests in the file
If anything that isn't minor breaks, skip copied tests and create followup tickets

The text was updated successfully, but these errors were encountered:

ghudgins added the team-cli label

ghudgins modified the milestones: Catalog 2, Catalog 3

mkenigs added team-cli and removed team-cli labels

Contributor

mkenigs commented May 20, 2024

Looks like the following should be unit tests:

'flox list' lists packages of environment in the current dir; shows different paths
'flox list' lists packages of environment in the current dir; shows different id
'flox list' hides packages not installed for the current system
'flox list' tolerates missing version

The following need to be modified to run with the catalog:

(this could be a unit test, but I think it's probably good to have at least one integration test for flox list?) 'flox list' lists packages of environment in the current dir; One package from nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment