Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set catalog feature flag for integration tests (activate) #1419

Open
ghudgins opened this issue May 8, 2024 · 3 comments
Open

set catalog feature flag for integration tests (activate) #1419

ghudgins opened this issue May 8, 2024 · 3 comments
Labels
team-cli Tickets relevant to the flox CLI team
Milestone

Comments

@ghudgins
Copy link
Contributor

ghudgins commented May 8, 2024

  • Copy any tests in activate.bats that are impacted by the catalog and run them with the catalog feature flag set. Make any small changes required to get them passing
  • Set FLOX_FEATURES_USE_CATALOG=true and _FLOX_USE_CATALOG_MOCK=/dev/null for all other tests in the file
  • If anything that isn't minor breaks, skip copied tests and create followup tickets
@ghudgins ghudgins added the team-cli Tickets relevant to the flox CLI team label May 8, 2024
@ghudgins ghudgins modified the milestones: Catalog 2, Catalog 3 May 8, 2024
@flox flox deleted a comment from ghudgins May 8, 2024
@mkenigs mkenigs added team-cli Tickets relevant to the flox CLI team and removed team-cli Tickets relevant to the flox CLI team labels May 9, 2024
@zmitchell
Copy link
Contributor

Notes:

  • Several tests install packages to an environment, so you'll need mock data for that series of responses to the /resolve endpoint. It looks like most of them just install hello so you won't need much.
  • Every test calls init. You probably want a constant that contains any mock init data, populate the environment variable with this data in project_setup since we init in project_setup. The constant lets you init in test bodies as well since some of them flox delete; flox init.
  • Several of these unit tests init during project_setup and then immediately delete and init in the test body. It's probably worth only doing an init when necessary for test times.

@mkenigs
Copy link
Contributor

mkenigs commented May 21, 2024

We're merging some more tests that use install in #1467, but the flox install can probably just be dropped, see #1467 (comment)

@limeytexan
Copy link
Contributor

We're merging some more tests that use install in #1467, but the flox install can probably just be dropped, see #1467 (comment)

Added patch to fix this in #1475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-cli Tickets relevant to the flox CLI team
Projects
None yet
Development

No branches or pull requests

4 participants