Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use toml_edit instead of custom templating #1064

Closed
mkenigs opened this issue Feb 21, 2024 · 1 comment · Fixed by #1333
Closed

Use toml_edit instead of custom templating #1064

mkenigs opened this issue Feb 21, 2024 · 1 comment · Fixed by #1333
Assignees
@oxcabe
Labels
greenkeeping team-cli Tickets relevant to the flox CLI team

Comments

@mkenigs
Copy link
Contributor

mkenigs commented Feb 21, 2024

In flox init, we're using a template manifest.toml with identifiers to substitute. But if we're going to programmatically edit the file, we should just use toml_edit

AC:

  • Use toml_edit instead of String::replace in flox init
@mkenigs mkenigs added team-cli Tickets relevant to the flox CLI team tech-debt labels Feb 21, 2024
@mkenigs mkenigs mentioned this issue Feb 21, 2024
Merged
@oxcabe
Copy link
Contributor

oxcabe commented Apr 16, 2024

I'll work on this one 👍

@oxcabe oxcabe mentioned this issue Apr 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
@oxcabe @mkenigs
@ysndr @dcarley @aakropotkin
refactor: parse manifest template to RawManifest, use toml_edit (#…
c4c62b4 
…1333)

## Proposed Changes

<!-- Describe the changes proposed in this pull request. -->
<!-- Please provide links to any issue(s) which are expected to be
resolved. -->
This PR replaces uses of `String::replace` for editing and populating
placeholders in `manifest.toml` to use `toml_edit` instead.

Closes #1064.

## Release Notes
N/A.
<!-- Describe any user facing changes. Use "N/A" if not applicable. -->


<!-- Many thanks! -->

---------

Co-authored-by: Matthew Kenigsberg <matthew@floxdev.com>
Co-authored-by: Yannik Sander <7040031+ysndr@users.noreply.github.com>
Co-authored-by: Dan Carley <dan.carley@gmail.com>
Co-authored-by: Alex Ameen <alex.ameen.tx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxcabe oxcabe

Labels
greenkeeping team-cli Tickets relevant to the flox CLI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: parse manifest template to RawManifest, use toml_edit oxcabe/flox
3 participants
@stahnma @oxcabe @mkenigs