Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vietnamese Telex] Uppercase error in Vietnamese Telex #2260

Open
thanhhocse96 opened this issue Jul 6, 2023 · 3 comments · May be fixed by #2267
Open

[Vietnamese Telex] Uppercase error in Vietnamese Telex #2260

thanhhocse96 opened this issue Jul 6, 2023 · 3 comments · May be fixed by #2267
Labels
bug A bug report

Comments

@thanhhocse96
Copy link
Contributor

thanhhocse96 commented Jul 6, 2023 •
edited

Short description

When add tone to Uppercase letter, the whole word become the uppercase letter:

  • "Ans" -> "ÁN", should be: "Án"
  • "Ais" -> "ÁI", should be: "Ái"
  • "Aif" -> "ÀI", should be: "Ài"

Steps to reproduce

  1. Chose Vietnamese Keyboard
  2. Click "Try out your setup"

Environment information

  • FlorisBoard Version: 0.4.0-alpha04 (90)
  • Install Source: IzzyOnDroid
  • Device: Nokia 6.1 plus
  • Android: 13 - LineageOS 12

error with Vietnamese Keyboard
@thanhhocse96 thanhhocse96 added the bug A bug report label Jul 6, 2023
@thanhhocse96
Copy link
Contributor Author

thanhhocse96 commented Jul 9, 2023 •
edited

After investigation, I have a assumption for the reason of this bug, @patrickgold and @Hayleia please preview this bug:
Bug Assumptions

Assumption after investigation:

In the method getActions, you get the key in composers/extension.json and uppercase the whole key when ever uppercase status trigger. And this lead to the uppercase bug.

Example:
Type: "Ans" => "ÁN", if you type a letter after that, eg: "h" => ÁNh. Should be: Ansh => Ánh

This bug only appear on the key start with Vowel: a, ă, â, e, ê, i, o, ô, ơ, u, ư and end with the Telex tone mark like: s, f, r, x, j, w.

Some example to recreate the bug:

  • Anhs sao => ÁNH sao (the key: "anhs")
  • Ansh sao => ÁNh sao (the key: "ans")
  • Ungw => ƯNG (the key: "ungw")
  • Unwg => ƯNg (the key: "unw")
  • Unsg => ÚNg (the key: "uns")

@Hayleia Hayleia linked a pull request Jul 14, 2023 that will close this issue
Open
@Hayleia
Copy link
Contributor

Hayleia commented Jul 15, 2023

Hello, can you try the debug build in the above pull request and confirm that it behaves the way you would expect it to?

@thanhhocse96
Copy link
Contributor Author

Tested. As Vietnamese, we thank you @Hayleia very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix uppercase behaviour with telex Hayleia/florisboard
2 participants
@Hayleia @thanhhocse96