From a7389d55b0acad1f77923fb4250f68a8bed5241a Mon Sep 17 00:00:00 2001 From: Marius456 Date: Wed, 6 Mar 2024 18:18:10 +0200 Subject: [PATCH 1/3] change linux webos launch cli --- packages/sdk-webos/src/deviceManager.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/sdk-webos/src/deviceManager.ts b/packages/sdk-webos/src/deviceManager.ts index 16ea5f3f12..f811e8f5de 100644 --- a/packages/sdk-webos/src/deviceManager.ts +++ b/packages/sdk-webos/src/deviceManager.ts @@ -73,10 +73,9 @@ export const launchWebOSimulator = async (c: RnvContext, target: string) => { if (!fsExistsSync(ePath)) { return Promise.reject(`Can't find simulator at path: ${ePath}`); } - if (isSystemWin) { + if (isSystemWin || isSystemLinux) { return executeAsync(c, ePath, { detached: true, stdio: 'ignore' }); } - await executeAsync(c, `${openCommand} ${ePath}`, { detached: true }); logSuccess(`Succesfully launched ${selectedOption}`); return true; From 5f0cda0f0e9c615a27715d15cf9d57eaa453d7e0 Mon Sep 17 00:00:00 2001 From: Marius456 Date: Fri, 8 Mar 2024 13:52:50 +0200 Subject: [PATCH 2/3] migrate options to preset --- packages/sdk-webos/src/deviceManager.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/sdk-webos/src/deviceManager.ts b/packages/sdk-webos/src/deviceManager.ts index f811e8f5de..c9dcaf19b3 100644 --- a/packages/sdk-webos/src/deviceManager.ts +++ b/packages/sdk-webos/src/deviceManager.ts @@ -74,9 +74,9 @@ export const launchWebOSimulator = async (c: RnvContext, target: string) => { return Promise.reject(`Can't find simulator at path: ${ePath}`); } if (isSystemWin || isSystemLinux) { - return executeAsync(c, ePath, { detached: true, stdio: 'ignore' }); + return executeAsync(c, ePath, ExecOptionsPresets.SPINNER_FULL_ERROR_SUMMARY); } - await executeAsync(c, `${openCommand} ${ePath}`, { detached: true }); + await executeAsync(c, `${openCommand} ${ePath}`, ExecOptionsPresets.FIRE_AND_FORGET); logSuccess(`Succesfully launched ${selectedOption}`); return true; }; From 030a1c72453c1c294d6850b7b3cf6aebf392136e Mon Sep 17 00:00:00 2001 From: Marius456 Date: Fri, 8 Mar 2024 16:13:25 +0200 Subject: [PATCH 3/3] small merge fix --- packages/sdk-webos/src/deviceManager.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/sdk-webos/src/deviceManager.ts b/packages/sdk-webos/src/deviceManager.ts index 60778bb01e..4fc08e9114 100644 --- a/packages/sdk-webos/src/deviceManager.ts +++ b/packages/sdk-webos/src/deviceManager.ts @@ -75,9 +75,9 @@ export const launchWebOSimulator = async (c: RnvContext, target: string | boolea if (isSystemWin || isSystemLinux) { return executeAsync(c, ePath, ExecOptionsPresets.SPINNER_FULL_ERROR_SUMMARY); } - + await executeAsync(c, `${openCommand} ${ePath}`, ExecOptionsPresets.FIRE_AND_FORGET); - logSuccess(`Succesfully launched ${selectedOption}`); + logSuccess(`Succesfully launched ${target}`); return true; };