Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structures in absorber trigers a warning about PML #1696

Open
tomflexcompute opened this issue May 10, 2024 · 2 comments
Open

Structures in absorber trigers a warning about PML #1696

tomflexcompute opened this issue May 10, 2024 · 2 comments
Assignees
Labels
Bug something isnt working

Comments

@tomflexcompute
Copy link
Contributor

When there is a structure completely inside the absorber boundary, it triggers a warning

WARNING: A bound of Simulation.structures[94] was
detected as being within the simulation PML. We
recommend extending structures to infinity or
completely outside of the simulation PML to avoid
unexpected effects when the structures are not
translationally invariant within the PML.

This seems to be related to the pml_thicknesses here actually includes not just PML but absorber as well. Therefore _validate_no_structures_pml returns a warning for structures in absorber too.

@tomflexcompute tomflexcompute added the Bug something isnt working label May 10, 2024
@momchil-flex
Copy link
Collaborator

I am wondering if we should change the message instead of completely removing the warning for Absorbers. Yes, absorbers may not diverge, but I feel like this could still be indicative of an unintended setup in some cases, e.g. this can create extra reflections if the users just didn't realize that they didn't extend their structures through. What do you think?

@tomflexcompute
Copy link
Contributor Author

Yeah that sounds good. As long as we can eliminate the confusion from the warning it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug something isnt working
Projects
None yet
Development

No branches or pull requests

2 participants