Fix pol vector #1694
Merged
Fix pol vector #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
approved these changes
May 10, 2024
|
Thanks @dbochkov-flexcompute. Can you just add a changelog item under fixed and I think this is good to merge and also fixes #1683 as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1683
It seems like our frontend polarization visualization was inconsistent with actual fields being injected. Frontend arrow was calculated sometimes based on summation and sometimes based on subtraction of
angle_phiandpol_angle, while on backend it is always summation. That is, rotation forangle_phiandpol_angleare always with respect to the positive direction of injection axis. Moreover the visualization was discontinuous between theta < 0, theta = 0, and theta > 0.Here's comparison between the visualized polarization vector (red) and extracted from actual fields (blue)
Now we just repeat the same steps for computing
_pol_vectoras the backend does for field computations. This seems to resolve all inconsistencies