Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flet/client for Linux: rename main binary from flet to flet_runner #3286

Open
lucasew opened this issue May 14, 2024 · 2 comments
Open

flet/client for Linux: rename main binary from flet to flet_runner #3286

lucasew opened this issue May 14, 2024 · 2 comments
Assignees

Comments

@lucasew
Copy link
Contributor

lucasew commented May 14, 2024

Please Describe The Problem To Be Solved
I am one of the maintainers of this package in nixpkgs. IMO the packaging now is very complete. I was the one that added the client to nixpkgs but there is a small annoying issue: both the client and the python library expose the flet command.

(Optional): Suggest A Solution

Just rename the main binary of the client from flet to flet_client. I think it can be done changing that binary name in CMakeLists.txt. It would need to also be changed in the code so Python knows how to launch the client.

If you guys for some reason don't care, a Nix-only fix wouldn't be hard too. A mv in a postInstall phase and a change in meta.mainProgram would give the same results without risk of breakage in your side.

@FeodorFitsner FeodorFitsner self-assigned this May 14, 2024
@FeodorFitsner
Copy link
Contributor

That makes sense. Will keep that in mind for next releases.

@FeodorFitsner
Copy link
Contributor

I'm going to do that for 0.24 or 0.25 release as part of #3163.

I suggest we name it flet_runner though. I don't like this old "Flet client" name, because it's no longer a client :)

@FeodorFitsner FeodorFitsner changed the title flet/client: rename main binary from flet to flet_client flet/client for Linux: rename main binary from flet to flet_runner May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants