Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up/clean up testing #313

Open
1 of 3 tasks
saraedum opened this issue Sep 4, 2022 · 0 comments
Open
1 of 3 tasks

Speed up/clean up testing #313

saraedum opened this issue Sep 4, 2022 · 0 comments
Labels
enhancement New feature or request performance refactoring

Comments

@saraedum
Copy link
Member

saraedum commented Sep 4, 2022 •
edited

Currently, it takes about 10 minutes to test all of flatsurf. That's slowing down development here so we should do something about it.

  • Profile slow tests
  • Parallelize tests further, i.e., register (or detect) individual tests (for individual template type arguments) in the Makefile so we can run in parallel with more granularity than just file granularity. (in Apply a Deformation to a Point #303)
  • Clarify who tests what. E.g., is FlatTriangulation::applyMatrix tested by flat_triangulation.test or by deformation.test? Maybe we should just split the tests up into individual files for the individual methods like FLINT does. What is tested should be indicated cleary by the tags. If something is tested elsewhere, we should just add an empty test that references the other place.
saraedum added a commit to saraedum/flatsurf that referenced this issue Sep 12, 2022
@saraedum
Undo splitting of test files
02b8945 
Since we now run tests fully in parallel this only creates more
confusion. We should instead clearly tag tests to make it clear who
tests what, see flatsurf#313.
saraedum added a commit to saraedum/flatsurf that referenced this issue Sep 12, 2022
@saraedum
Cleanup test tagging
c398eda 
see flatsurf#313.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance refactoring
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saraedum