Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turnNearestToDirection() fails for marked points #276

Open
saraedum opened this issue Oct 18, 2021 · 0 comments
Open

turnNearestToDirection() fails for marked points #276

saraedum opened this issue Oct 18, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@saraedum
Copy link
Member

The implementation of turnNearestToDirection() which is used by SaddleConnection::inPlane() contains an assertion that can (incorrectly) fail at marked points:

LIBFLATSURF_CHECK_ARGUMENT(surface.fromHalfEdge(source).ccw(direction) != CCW::COLLINEAR || surface.fromHalfEdge(source).orientation(direction) != ORIENTATION::OPPOSITE, "Direction " << direction << " does not single out a unique plane at " << source << ". Cannot decide which way to the source edge.");
@saraedum saraedum added the bug Something isn't working label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant