New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unneeded session_id? #1310
Comments
Yeah, looks like a copy/paste from the |
Should this actually be |
Can you check if any of the impls actually return this (see ScreenCast and others too)? This looks much like a copy-paste from the |
On Mon, 25 Mar 2024 03:57:57 -0700 Peter Hutterer ***@***.***> wrote:
Can you check if any of the impls actually return this (see ScreenCast and others too)? This looks much like a copy-paste from the `.portal` where the client passes the token and the portal returns the handle. Since it's the impl this isn't needed here (iirc, I've paged parts of all this out) so it could be dropped.
I'm not seeing any session_ids in the impls provided by xdg-desktop-portal-gnome.
|
Operating System
n/a
XDG Desktop Portal version
Git
XDG Desktop Portal version (Other)
No response
Desktop Environment
Deepin
Desktop Environment (Other)
No response
Expected Behavior
Docs describe things that are in use/applicable.
Current Behavior
Docs for the impl of CreateSession for some portals describe a "session_id" which serves no clear purpose.
It doesn't seem to be the same as the session handle, and the impl doesn't need to return that anyway. xdg-desktop-portal sources don't make use of that return value.
Is that field a nonexistent phantom coming from some copy-paste error?
Steps to Reproduce
results
vardictsession_id
Anything else we should know?
No response
The text was updated successfully, but these errors were encountered: