Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.freedesktop.Notifications.ActivationToken support #406

Open
ilya-fedin opened this issue Nov 28, 2022 · 0 comments · May be fixed by #468
Open

org.freedesktop.Notifications.ActivationToken support #406

ilya-fedin opened this issue Nov 28, 2022 · 0 comments · May be fixed by #468

Comments

@ilya-fedin
Copy link

org.freedesktop.Notifications spec has ActivationToken signal since a year: https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/43

Would be nice if xdg-desktop-portal-gtk mapped this to desktop-startup-id / activation-token keys of platform_data argument when calling org.freedesktop.Application.Activate{,Action}
jsparber added a commit to jsparber/xdg-desktop-portal-gtk that referenced this issue Mar 1, 2024
@jsparber
notification: Set correct platform data for action activation
2f68694 
Since [1] FDO notifications can transfer a `ActivateToken` to the client
application, we can use this token to set the correct platform data to
get wayland startup notification working correctly.
GNOME Shell gained the feature already in [2], so this is the last piece
missing to get rid of the annoying "<Application> is ready" notifications,
when clicking on a notification.

We can set the platform data only for actions that are activated via
`org.freedesktop.Application`.

Fixes: flatpak#406

[1] https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a470004d
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3199/
@jsparber jsparber linked a pull request Mar 1, 2024 that will close this issue
Open
jsparber added a commit to jsparber/xdg-desktop-portal-gtk that referenced this issue Mar 2, 2024
@jsparber
notification: Set correct platform data for action activation
6d1d0b1 
Since [1] FDO notifications can transfer a `ActivateToken` to the client
application, we can use this token to set the correct platform data to
get wayland startup notification working correctly.
GNOME Shell gained the feature already in [2], so this is the last piece
missing to get rid of the annoying "<Application> is ready" notifications,
when clicking on a notification.

We can set the platform data only for actions that are activated via
`org.freedesktop.Application`.

Fixes: flatpak#406

[1] https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a470004d
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3199/
jsparber added a commit to jsparber/xdg-desktop-portal-gtk that referenced this issue Apr 17, 2024
@jsparber
notification: Set correct platform data for action activation
7daf2a7 
Since [1] FDO notifications can transfer a `ActivateToken` to the client
application, we can use this token to set the correct platform data to
get wayland startup notification working correctly.
GNOME Shell gained the feature already in [2], so this is the last piece
missing to get rid of the annoying "<Application> is ready" notifications,
when clicking on a notification.

We can set the platform data only for actions that are activated via
`org.freedesktop.Application`.

Fixes: flatpak#406

[1] https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a470004d
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3199/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notification: Set correct platform data for action activation jsparber/xdg-desktop-portal-gtk
1 participant
@ilya-fedin