Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing old object on watchEvent #515

Open
mhkarimi1383 opened this issue Jul 15, 2023 · 6 comments · May be fixed by #517
Open

Accessing old object on watchEvent #515

mhkarimi1383 opened this issue Jul 15, 2023 · 6 comments · May be fixed by #517
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mhkarimi1383
Copy link

Is your feature request related to a problem? Please describe.

Describe the solution you'd like to see
a field called oldObject just like object

Describe alternatives you've considered
using validation webhooks

Additional context
@nabokihms
Copy link
Contributor

@mhkarimi1383 hello! Could you please elaborate?
This is not clear in which case do you want to receive an old object. Only for validating?
What do you want to validate then?

@mhkarimi1383
Copy link
Author

@nabokihms, Hi, I'm working on this PR on my project,
mhkarimi1383/reflector#3

As you can see I want to have old object to compare changes when Object is Modified

@nabokihms
Copy link
Contributor

Got it. Thanks for the explanation.

@nabokihms nabokihms added enhancement New feature or request help wanted Extra attention is needed labels Jul 16, 2023
@mhkarimi1383
Copy link
Author

Any updates on this?

@nabokihms
Copy link
Contributor

This feature is currently not in our roadmap, so probably no one from the team will pick it up in the nearest future.

Yet we are always welcome for contributions!

@mhkarimi1383
Copy link
Author

mhkarimi1383 commented Jul 24, 2023 •
edited

@nabokihms I have made a PR that will fix this I think

@mhkarimi1383 mhkarimi1383 linked a pull request Jul 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ feat: Accessing old object on watchEvent mhkarimi1383/shell-operator
2 participants
@mhkarimi1383 @nabokihms