Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid namespace name selectors in hooks documentation examples #333

Open
mtheck opened this issue Nov 11, 2021 · 1 comment
Open

Invalid namespace name selectors in hooks documentation examples #333

mtheck opened this issue Nov 11, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@mtheck
Copy link

mtheck commented Nov 11, 2021

There are few wrong examples with invalid namespace nameSelector attribute missing the intermediate matchNames attribute:
@nabokihms
Copy link
Contributor

nabokihms commented Nov 11, 2021 •
edited

@mtherreault, thank you! Good catch. Do you mind going ahead and opening a PR with the fix?

@nabokihms nabokihms added the help wanted Extra attention is needed label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtheck @nabokihms