Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestFlacon::testTextCodecs(02 - IBM866.src) fails on FreeBSD #229

Open
danfe opened this issue May 9, 2024 · 5 comments
Open

TestFlacon::testTextCodecs(02 - IBM866.src) fails on FreeBSD #229

danfe opened this issue May 9, 2024 · 5 comments
Labels
done The task is done, but not yet in the release.

Comments

@danfe
Copy link

danfe commented May 9, 2024

The latest version 11.4.0 fails to pass the test suite on FreeBSD, apparently due to iconv-related peculiarities:

PASS   : TestFlacon::testTextCodecs(01 - windows-1251.src)
FAIL!  : TestFlacon::testTextCodecs(02 - IBM866.src) Unable to open iconv_open for IBM866: Invalid argument
Loc: [<long-path-stripped>/work/flacon-11.4.0/tests/test_textcodecs.cpp(71)]
PASS   : TestFlacon::testTextCodecs(03 - ISO-8859-5.src)

So it doesn't like IBM866 for some reason, and it's in fact not listed on FreeBSD as available codeset name:

$ iconv -l | grep IBM866
CP866 866 CSIBM866 MSCP866

This is contrary to GNU/Linux (Ubuntu 20.04.2):

$ iconv -l | grep IBM866
CSIBM866//
IBM866//
IBM866NAV//
@SokoloffA
Copy link
Member

Hi, Alexey!
Changing the name is not a problem, but I need to make sure that the autodetect works correctly.

What the following command returns?

echo "Привет" | iconv -t cp866 | uchardet

@danfe
Copy link
Author

danfe commented May 9, 2024

echo "Привет" | iconv -t cp866 | uchardet

It returns IBM866 but that's probably because uchardet is the same on both systems, while iconv implementations differ.

@SokoloffA
Copy link
Member

Please test issue_229 branch

@danfe
Copy link
Author

danfe commented May 9, 2024

Please test issue_229 branch

Totals: 370 passed, 0 failed, 0 skipped, 0 blacklisted, 178217ms :-)

@SokoloffA SokoloffA added the done The task is done, but not yet in the release. label May 9, 2024
@SokoloffA
Copy link
Member

I put it to the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done The task is done, but not yet in the release.
Projects
None yet
Development

No branches or pull requests

2 participants