Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Customizable start date for shopify__calendar #64

Open
2 of 4 tasks
brian-equilife opened this issue Aug 25, 2023 · 2 comments
Open
2 of 4 tasks

[Feature] Customizable start date for shopify__calendar #64

brian-equilife opened this issue Aug 25, 2023 · 2 comments
Labels
enhancement New feature or request status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@brian-equilife
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently the Shopify__calendar has a start date of 1/1/2019. I have orders and customers from 2018. Under the current structure customer_chort has customers showing 0 orders in month 1. To be in a given cohort you need to have at least 1 order in month 1 since that is what qualifies you. These customers had their first order in 2018 but their cohort_month 1 is calculated starting 1/1/2019. I've attached sample data to illustrate the scenario. I've removed the customer_id everything else is as created by the dbt package.

customer_cohorts_example_data.csv

Describe alternatives you've considered

I could clone the repository and modify it, but I'm just learning this stuff so I'd prefer a variable or earlier start data for the spine.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@brian-equilife brian-equilife added the enhancement New feature or request label Aug 25, 2023
@fivetran-jamie fivetran-jamie added type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality labels Aug 28, 2023
@fivetran-jamie
Copy link
Contributor

Hi there @brian-equilife thanks for taking the time to open this!

I think making this start_date customizable would definitely be beneficial to everyone using the package! IMO we should make a shopify__calendar_start_date variable, with the default value remaining 2019-01-01 so as to not to have a breaking change on our hands.

if that sounds good to you, the team can work on slotting this into an upcoming sprint

@brian-equilife
Copy link
Author

That sounds amazing. Thank you @fivetran-jamie

@fivetran-jamie fivetran-jamie added the status:accepted Scoped and accepted into queue label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

No branches or pull requests

2 participants