Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Apply more rigorous testing to macros #143

Open
fivetran-joemarkiewicz opened this issue Feb 23, 2024 · 0 comments
Open

[FEATURE] - Apply more rigorous testing to macros #143

fivetran-joemarkiewicz opened this issue Feb 23, 2024 · 0 comments
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Feature Description

A lot of effort has been made over the past year to include full coverage of testing for the fivetran_utils package to test against all Fivetran dbt packages which reference this package as a dependency. The full coverage feature was achieved within PR #118. This full coverage test essentially runs a dbt compile and dbt run against every single Fivetran dbt package. This is great, and ensures we are testing the packages compile and run with the updates to this package; however, we have found that there are still notable gaps in this design. For example:

  • We should be able to ensure that when we update a macro it will result in the expected behavior across all destinations
  • When creating a new macro we should be able to ensure it works as expected and does not conflict with any other macros
  • We should be able to test basic assertions related to the behavior of the macros and how they should behave in the individual packages.

This feature request is to apply the above tests to the Fivetran Utils package in order to ensure more stable releases and more frequent updates as well.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant