Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of Discourse comment embeds. #76

Open
bmann opened this issue Aug 4, 2022 · 2 comments
Open

Styling of Discourse comment embeds. #76

bmann opened this issue Aug 4, 2022 · 2 comments
Labels
design design & styling

Comments

@bmann
Copy link
Member

bmann commented Aug 4, 2022

Screen Shot 2022-08-04 at 3 24 45 PM

Screenshot of comments on Wallet Stack https://fission.codes/blog/wallet-stack/

Dark mode styling! Not sure what we should do here, leaving this as a note for future design consideration.

@bmann bmann added the design design & styling label Aug 4, 2022
@avivash
Copy link
Member

avivash commented Aug 5, 2022

@bmann the css classes are suddenly appearing in the embedded iframe(now that it's deployed to fission.codes - which, in hindsight, makes sense 😅 )! so i should actually be able to clean up the styles/create a dark mode skin pretty quickly now 🙌🏼 (at least a simple version until we have time to do a full design pass)

@avivash
Copy link
Member

avivash commented Aug 6, 2022

just did a quick/dirty pass at adding some light theming to the comments for light and dark mode. The logo that's loaded into the light mode template seems to be intended for dark mode, so I'm hiding it in light mode for now. I'll need to check with Nolo as to whether or not we can edit the markup. Otherwise, I can do some hacky CSS to get the logo working for both light/dark modes 🤷🏼

Light Mode:
image

Dark Mode:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design design & styling
Projects
None yet
Development

No branches or pull requests

2 participants