Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update append endpoint to not overwrite #618

Open
bgins opened this issue Jul 11, 2022 · 1 comment
Open

Update append endpoint to not overwrite #618

bgins opened this issue Jul 11, 2022 · 1 comment
Labels
💗 enhancement New feature or request

Comments

@bgins
Copy link
Contributor

bgins commented Jul 11, 2022

@expede and I were discussing the in-progress append endpoint feature on the append-endpoint branch. In the current implementation, files that are uploaded to the endpoint will replace existing files, an action which should require Destroy or Super_User capability.

Appending should not replace files, but instead it should keep copies of the old files available when adding a new file with the same name.

A bit of design will be needed here. Say a user has previously uploaded a cat.jpg to an app. Later, they upload a second file also named cat.jpg. Is the original file renamed to cat2.jpg? Or should the new file be named cat2.jpg?

Let's discuss our options and how they will work for developer use cases.

@bgins bgins added the 💗 enhancement New feature or request label Jul 11, 2022
@bmann
Copy link
Member

bmann commented Jul 11, 2022

This is after a first release. So for now — overwrite files with the same name.

iCloud / Apple MacOS do cat 2.jpg (Space and next number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💗 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants