Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publish command aware of uploads directory #617

Open
bgins opened this issue Jul 8, 2022 · 1 comment
Open

Make publish command aware of uploads directory #617

bgins opened this issue Jul 8, 2022 · 1 comment
Labels
💗 enhancement New feature or request

Comments

@bgins
Copy link
Contributor

bgins commented Jul 8, 2022

NB: Feature requests will only be considered if they solve a pain

Summary

Problem

If a developer appends to an app, then publishes the app, their appended files will no longer be available in the app.

Impact

Confusing developer experience. A developer will not expect their uploads to disappear when they publish.

Solution

Make the publish command aware of the uploads directory to preserve it.

As a rough sketch:

  • Check if uploads exists and get the CID for it
  • Get a root CID for the app as published by the CLI
  • Stitch the uploads directory back into the app
  • Complete the publish and return the CID of the app with uploads put back in

There are likely more details to consider. For example, what happens when an app has an uploads directory locally.

@bgins bgins added the 💗 enhancement New feature or request label Jul 8, 2022
@expede
Copy link
Member

expede commented Jul 8, 2022

@bgins we should talk about this in more detail. I actually think that this breaks user expectation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💗 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants