Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default settings changed in game not applied to local settings storage #942

Open
MaxCWhitehead opened this issue Mar 25, 2024 · 0 comments
Labels
kind:bug Something isn't working scope:small A small and well-defined task

Comments

@MaxCWhitehead
Copy link
Collaborator

MaxCWhitehead commented Mar 25, 2024

Description

IWhen updating build on steamdeck, there is Ragdoll control in settings, but it is set to None. It seems that engine does not handle missing fields in settings when new ones are added. Maybe we need to differentiate specifically between missing input in stored settings and write default, and a none input that was set by player. (Explicitly set none in settings?)

Or we could have a default settings file, and user overrides, and overlay it, that way when game runs it always updates default, to make sure changes are applied correctly.

EDIT: I think the most right thing to do is probably some sort of patch function, overlay/merge could work if just adding stuff, but if renaming, wouldn't cut it.

Workaround:

EDIT: I found that we have a handy dandy reset button in settings, player can hit reset to get default controls, slightly inconvenient but ok for now.

To Reproduce

Not entirely sure - but something like install a old build of game pre-ragdoll, run it, then run ragdoll version, see if ragdoll control setting is set to default or set to none.

EDIT: Also seem to be able to delete the ragdoll lines from storage file and the reboot to simulate this.

Expected Behavior

Settings should reflect default unless overridden by user.

Additional Context

No response

Log Messages

No response

@MaxCWhitehead MaxCWhitehead added kind:bug Something isn't working scope:small A small and well-defined task labels Mar 25, 2024
@MaxCWhitehead MaxCWhitehead self-assigned this Mar 25, 2024
@MaxCWhitehead MaxCWhitehead removed their assignment Apr 10, 2024
@MaxCWhitehead MaxCWhitehead changed the title Ragdoll button default settings not applied to settings storage Default settings changed in game not applied to local settings storage May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working scope:small A small and well-defined task
Projects
None yet
Development

No branches or pull requests

1 participant