Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike Shoes are still in player's hand after equipping #929

Closed
MaxCWhitehead opened this issue Mar 22, 2024 · 1 comment · Fixed by #993
Closed

Spike Shoes are still in player's hand after equipping #929

MaxCWhitehead opened this issue Mar 22, 2024 · 1 comment · Fixed by #993
Assignees
@Breadp4ck
Labels
good first issue Good for newcomers help wanted Extra attention is needed scope:small A small and well-defined task

Comments

@MaxCWhitehead
Copy link
Collaborator

MaxCWhitehead commented Mar 22, 2024 •
edited

Description

After equipping spike shoe they are still in the player's hand and may be dropped, while remaining on player's feet.

To Reproduce

Pickup spike shoe (Level 3 should have some).

Expected Behavior

Spike shoe should be consumed once equipped?

Additional Context

No response

Log Messages

No response
@MaxCWhitehead MaxCWhitehead added help wanted Extra attention is needed good first issue Good for newcomers scope:small A small and well-defined task labels Mar 23, 2024
@Breadp4ck
Copy link
Contributor

The item is called Stomp Boots. So, we may either drop or despawn them.

In the first approach, if the player also has a hat, there will be two (or three!) items left at the death location, which is not very convenient. We can solve this by giving either boots or hat some inertia for easier picking up. But I think that will be a little bit messy anyway.

I prefer the second approach. However, it may be not very enjoyable, since players won't be able to pick up the boots of the player they've slain.

To implement that, there must be some systems which despawn Attachments or something? I want to try to do something.

@Breadp4ck Breadp4ck mentioned this issue May 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@Breadp4ck
feat: Respawn Stamp Boots when a player was killed (#993)
d27a8b7 
This PR closes #929.

I made `WornStompBoots` component that marks the entity that created
when the player used the boots. When the player is killed
(`PlayerKilled`) and a related entity with `WornStompBoots` exists
(`stomp_boots` in `WearingStompBoots`), I respawn the entity with
`StompBoots` component and remove marker `WornStompBoots`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Breadp4ck Breadp4ck

Labels
good first issue Good for newcomers help wanted Extra attention is needed scope:small A small and well-defined task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Respawn Stamp Boots when a player was killed Breadp4ck/jumpy
2 participants
@MaxCWhitehead @Breadp4ck