Marriage Report Filter Broken for Families With Multiple Marriages

[miqrogroove]

I'm running a marriage report with the following criteria ...

Place: Michigan
Start: 01 JAN 1944
End: 31 DEC 1944

There are 9 families listed in the report. All of the results are correct except for the 2nd-to-last entry. It's showing a marriage that took place in Indiana during 1936.

If I switch the date range to 1941, it adds another strange result from Florida during 1935.

Running webtrees v2.1.18 on PHP v8.3.0.

[miqrogroove]

So here's what I'm thinking ...

webtrees/resources/xml/reports/marriage_report.xml

Line 60 in e96e110

<List list="family" filter1="MARR:PLAC CONTAINS $marrplace" filter2="MARR:DATE GTE $marrdate1" filter3="MARR:DATE LTE $marrdate2" filter4="NAME CONTAINS $name" sortby="$sortby">

This filter is applied at the Family level, rather than the Marriage level.

In my test case, the Family contains 2 different marriages, as follows:

0 @F1@ FAM
1 MARR
2 DATE 1936
2 PLAC Indiana, USA
1 MARR
2 DATE 1945
2 PLAC Michigan, USA

Now, while neither of those marriages can match my search criteria, in fact the Family does match.

The place filter1 matches the 2nd marriage. The start date filter2 matches the 2nd marriage. The end date filter3 matches the 1st marriage.

The result is a false positive. The filter design effectively assumes a family can never have more than one marriage.

Further testing shows another bug: By changing the filter to Michigan, 1945, the report displays the correct family with the wrong marriage details.

[arbor95]

I think the possibilty to enter more than one date for the marriage ( without using a specifying type), that is establishing the family, should not be possible (and is imho a gedcom design bug), although family in gedcom has an other meaning than we normaly use.
If I do not know the correct date, I would explain that within a note.

[arbor95]

You have to create a new family in that rare cases

[arbor95]

No, if your gedcom - input is wrong, you can not expect correct results.