Fix: unescaped output when creating new records in modals

fisharebest · Oct 1, 2021 · 6d966f6 · 6d966f6
1 parent 8c13cfd
commit 6d966f6
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 8 deletions.
diff --git a/resources/views/modals/create-location.phtml b/resources/views/modals/create-location.phtml
@@ -43,7 +43,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })

diff --git a/resources/views/modals/create-media-object.phtml b/resources/views/modals/create-media-object.phtml
@@ -46,7 +46,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })

diff --git a/resources/views/modals/create-note-object.phtml b/resources/views/modals/create-note-object.phtml
@@ -43,8 +43,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
-          option.innerHTML = data.text;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })

diff --git a/resources/views/modals/create-repository.phtml b/resources/views/modals/create-repository.phtml
@@ -45,7 +45,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })

diff --git a/resources/views/modals/create-source.phtml b/resources/views/modals/create-source.phtml
@@ -43,7 +43,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })

diff --git a/resources/views/modals/create-submission.phtml b/resources/views/modals/create-submission.phtml
@@ -43,7 +43,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })

diff --git a/resources/views/modals/create-submitter.phtml b/resources/views/modals/create-submitter.phtml
@@ -43,7 +43,6 @@ use Fisharebest\Webtrees\Tree;
           // If this modal was activated by the "new" button in a select2
           // edit control, then insert the result and select it.
           let option = new Option(data.text, data.id, true, true);
-          option.innerHTML = option.innerText;
 
           $(select)
             .select2({ escapeMarkup: (x) => x })