Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken links #83449

Open
lovistawiah opened this issue Apr 13, 2024 · 14 comments
Open

Fix Broken links #83449

lovistawiah opened this issue Apr 13, 2024 · 14 comments

Comments

@lovistawiah
Copy link
Contributor

馃悶 Problem
The contributors.md file contains broken links, which hinder users from accessing other GitHub accounts. These broken links could be leading to non-existent pages on GitHub.

馃幆 Goal
The goal is to fix the broken links or remove non-working links entirely in the contributors.md file. This change is important because broken links does not ensure the goals of the project.

馃挕 Possible solutions

  1. Review each link in the contributors.md file manually to identify broken links.
  2. Replace broken links with updated or correct URLs.
  3. Update the contributors.md file with the corrected links.

馃搵 Steps to solve the problem

  1. Start by reviewing the contributors.md file to identify broken links.
  2. Replace broken links with the correct URLs or remove them if the GitHub accounts are not found.
  3. Test the updated links to ensure they are working as expected.
  4. Add, commit, and push the changes to the repository.
  5. Submit a pull request addressing this issue.
  6. Ask for reviews and feedback on the pull request.
@lovistawiah lovistawiah changed the title Fixing Broken links Fix Broken links Apr 13, 2024
@StepTheGlow
Copy link

馃悶 Problem The contributors.md file contains broken links, which hinder users from accessing other GitHub accounts. These broken links could be leading to non-existent pages on GitHub.

馃幆 Goal The goal is to fix the broken links or remove non-working links entirely in the contributors.md file. This change is important because broken links does not ensure the goals of the project.

馃挕 Possible solutions

  1. Review each link in the contributors.md file manually to identify broken links.
  2. Replace broken links with updated or correct URLs.
  3. Update the contributors.md file with the corrected links.

馃搵 Steps to solve the problem

  1. Start by reviewing the contributors.md file to identify broken links.
  2. Replace broken links with the correct URLs or remove them if the GitHub accounts are not found.
  3. Test the updated links to ensure they are working as expected.
  4. Add, commit, and push the changes to the repository.
  5. Submit a pull request addressing this issue.
  6. Ask for reviews and feedback on the pull request.

i will try to do this although this is HARD

@lovistawiah
Copy link
Contributor Author

It seems pretty HARD to do this. I also want to help.

@StepTheGlow
Copy link

It seems pretty HARD to do this. I also want to help.

uh......bro i think it's fixed

@kenshanta
Copy link

what's the update on this @lovistawiah

@lovistawiah
Copy link
Contributor Author

Not been active for sometime due to some challenges and learning new skills - prompt engineering
I will do quick pull to keep up with latest and get back to @kenshanta with the update.
thanks for your patience

@lovistawiah
Copy link
Contributor Author

Before I start updating the contributors.md file, I think it should be stated clearly to new contributors to follow.

[profile name](https://www.example.com)
  1. replace profile name with GitHub username
  2. replace link with GitHub link

the preview should be:

@kenshanta
Copy link

@lovistawiah that's another topic, won't open an issue for it since beginners are bound to make mistakes no matter how crisp & clear the documentation is.

There can always be a pull request tackling this "issue".
But since merging Pull requests on this repository is quite a slow process i fear there could be conflicts when other contribute PRs are merged.

So it needs to be done only of prioritized and approved by the maintainer themselves

@StepTheGlow
Copy link

StepTheGlow commented May 12, 2024

Is there a fork we can work on? We can collaborate to fix contributors.md as there are many errors made by beginners.

@kenshanta
Copy link

@Roshanjossey we need your input on the matter

@lovistawiah
Copy link
Contributor Author

I have been working tirelessly on this issue. I will open PR today.

@lovistawiah lovistawiah mentioned this issue May 16, 2024
4 tasks
@StepTheGlow
Copy link

I have been working tirelessly on this issue. I will open PR today.

May I offer my assistance, please?

@lovistawiah
Copy link
Contributor Author

lovistawiah commented May 17, 2024

I am having difficulties fetching the latest update of the repo.
I want to fix the new errors added to the Contributors.md file.
Can anyone assist me to achieve the result
git commands used so far

git pull
git fetch origin 
git fetch --all --prune

I have also checked origin details using

git remote show origin

@kenshanta
Copy link

things to keep in mind when sharing an issue for other developers to debug:

  • specify the relevant information about your local setup. (in this case the repo and branch you are working on)
  • what you are trying to do
  • what is the bottleneck halting your deployment The more detailed information the better
  • what did you try so far and what was the outcome

Coming back to your issue, did you recently fork the repo?
if yes you don't need to pull as you have the latest changes
otherwise which repo & branch are you trying to update and to which commit?

what does the terminal print in the logs when you do git pull?

I am having difficulties fetching the latest update of the repo. I want to fix the new errors added to the Contributors.md file. Can anyone assist me to achieve the result git commands used so far

git pull
git fetch origin 
git fetch --all --prune

I have also checked origin details using

git remote show origin

@kenshanta
Copy link

Guys this issue needs to be handled by the maintainer as he controls the active links.
So i don't understand what you're working on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants