-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GitHub Actions for CI #77
Comments
Useful actions: https://github.com/actions-rs |
I'm trying to understand your ci setup. I'm quite lost. So far I have (there's stuff elided) Pull Req >
Commit / Push >
|
Honestly I'm not sure what's happening in the Makefile abuse myself. But that seems correct. There's not much reason to use Docker for builds these days, IMO. The plan was to rip everything out and use #92 for toolchain installation in CI. |
Publishing on tag creation is definitely the way to go. That's how the system works now. The publish script (perhaps a more accurate name would be try_publish) checks for a tag (in $TRAVIS_TAG) that matches the crate version before pushing. My understanding was that this is how you do it with Travis. We didn't publish on PRs because the crates.io secret wasn't available to them, and they couldn't be tagged. I used Docker originally because back when I started this project the way to get the frc compiler and libraries was an Ubuntu 16 package, which Travis did not support. I think they were 14 only at the time. Moving to Github actions and the newer toolchains alleviates that issue. Unless the Dockerfile aids cross platform development there isn't much reason to keep it. |
I've made a draft pr. However, I don't know how to use docker... I can build inside the container (save preexisting bugs), but not otherwise. I don't know if this is a bug or a problem with my system. I don't expect you guys to debug for me, I'll try to fix my c++ toolchain EDIT: Yeah I don't have the skills to finish this. I'm getting a linker problem when building hal, I can't find the gradle task to install the toolchain, and the toolchain's manual installer segfaults. I'll leave my pr open, as it has most of the work you want done (namely the publish workflow). |
No description provided.
The text was updated successfully, but these errors were encountered: