Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ux(headless-client): remove auto-detected IPC service mode #4907

Closed
ReactorScram opened this issue May 7, 2024 · 0 comments · Fixed by #4953
Closed

ux(headless-client): remove auto-detected IPC service mode #4907

ReactorScram opened this issue May 7, 2024 · 0 comments · Fixed by #4953
Assignees
@ReactorScram
Labels
area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients needs triage Issues opened by the public or need further labeling

Comments

@ReactorScram
Copy link
Collaborator

ReactorScram commented May 7, 2024 •
edited

The IPC service and headless Client are really two different things that share a lot of code down in the shared connlib crates.

If a user is setting up the headless Client, they aren't going to want the IPC service. If they're setting up the GUI, they probably won't need the headless Client. If they do need both, they should be separate files to avoid package conflicts. If they're separate files, they might as well be separate binaries and separate packages.

This will simplify some of the code for #4903 too

While doing this, also make the function names better. Stuff like run_ipc_service and ipc_listen is not intuitive at all. If there's enough layers maybe they should just get numbers.
@ReactorScram ReactorScram added area/linux_client Linux client needs triage Issues opened by the public or need further labeling area/tauri_client The Windows and Linux Tauri GUI clients labels May 7, 2024
@ReactorScram ReactorScram self-assigned this May 7, 2024
This was referenced May 8, 2024
Closed
Merged
@ReactorScram ReactorScram linked a pull request May 13, 2024 that will close this issue
refactor(headless-client): deprecate subcommands for now #4953
Merged
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@ReactorScram
refactor(headless-client): deprecate subcommands for now (#4953)
b444dee 
Closes #4907

They're still accepted, but the binary entirely determines the behavior.
This makes the code for CLI parsing and token handling simpler with
fewer branches, so it's easier to be sure it's correct.

Replaces #4942 which isn't doing what I intended anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReactorScram ReactorScram

Labels
area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients needs triage Issues opened by the public or need further labeling
Projects
None yet
Milestone
No milestone
1 participant
@ReactorScram