Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to order the ASWebAuthenticationSession window front on macOS #4818

Closed
jamilbk opened this issue Apr 29, 2024 · 0 comments · Fixed by #5090
Closed

Attempt to order the ASWebAuthenticationSession window front on macOS #4818

jamilbk opened this issue Apr 29, 2024 · 0 comments · Fixed by #5090
Assignees
Labels
area/apple_client Issues related to the Apple client kind/bug Something isn't working kind/UX Changes related specifically to overall user experience and product quality

Comments

@jamilbk
Copy link
Member

jamilbk commented Apr 29, 2024

Users are still reporting window order weirdness with ASWebAuthenticationSession. We need to see if there's any way possible to bring the newly-opened window to focus rather than letting macOS handle it.

@jamilbk jamilbk added kind/bug Something isn't working area/apple_client Issues related to the Apple client kind/UX Changes related specifically to overall user experience and product quality labels Apr 29, 2024
@jamilbk jamilbk self-assigned this Apr 29, 2024
@jamilbk jamilbk modified the milestone: 05/24 Apr 29, 2024
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
When the menu was clicked, the system would show it without activating
the app. This meant that other actions launched from the menu like `Sign
in` could sometimes happen without their respective window coming to the
foreground.

To fix it, we need more control over how the menu is displayed. So we
add a click handler and open the menu manually. Note that to do this, we
need to ensure `statusItem.menu = nil` otherwise the system will default
to showing the menu for us, and not firing our handler.

fixes #4818
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
When the menu was clicked, the system would show it without activating
the app. This meant that other actions launched from the menu like `Sign
in` could sometimes happen without their respective window coming to the
foreground.

To fix it, we need more control over how the menu is displayed. So we
add a click handler and open the menu manually. Note that to do this, we
need to ensure `statusItem.menu = nil` otherwise the system will default
to showing the menu for us, and not firing our handler.

fixes #4818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apple_client Issues related to the Apple client kind/bug Something isn't working kind/UX Changes related specifically to overall user experience and product quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant