Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMemPortConfig driver broken due to no loadmem.h present and other loadmem issues #1686

Open
3 tasks done
abejgonzalez opened this issue Jan 8, 2024 · 1 comment
Open
3 tasks done
Labels
bug Something isn't working

Comments

@abejgonzalez
Copy link
Contributor

Background Work

FireSim Version and Hash

Current main

OS Setup

N/A

Other Setup

Current Behavior

NoMemPortConfig fails due to not finding loadmem.h in the build (normally it is included by default).

Expected Behavior

NoMemPortConfig should build.

Other Information

This is the fix

diff --git a/sim/midas/src/main/cc/entry.cc b/sim/midas/src/main/cc/entry.cc
index d1766090a..5f6667397 100644
--- a/sim/midas/src/main/cc/entry.cc
+++ b/sim/midas/src/main/cc/entry.cc
@@ -10,6 +10,7 @@
 #define GET_INCLUDES
 #include "FireSim-generated.const.h"
 #undef GET_INCLUDES
+#include "bridges/loadmem.h" // always ensure that loadmem.h header is present for tsibridge to use loadmem

 #define GET_METASIM_INTERFACE_CONFIG
 #define GET_SUBSTRUCT_CHECKS
@abejgonzalez abejgonzalez added the bug Something isn't working label Jan 8, 2024
@abejgonzalez
Copy link
Contributor Author

template <typename T>
 T *get_widget_opt() {
   auto it = widgets.find(&T::KIND);
   if (it == widgets.end() || it->second.size() != 1)
     return nullptr;
   return static_cast<T *>(it->second[0].get());
 }

Probably need to use this too.

@abejgonzalez abejgonzalez changed the title NoMemPortConfig broken due to no loadmem.h present NoMemPortConfig driver broken due to no loadmem.h present and other loadmem issues Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant