Bug in handle-results.py

[novobruna]

Background Work

• Yes, I searched the mailing list
• Yes, I searched prior issues
• Yes, I searched the documentation

FireSim Version and Hash

1.17.0-0-g07efa6a6d

OS Setup

<!-- copy/paste the output of `uname -a; lsb_release -a` below -->

Linux fpga.cnfm.fr 3.10.0-1160.81.1.el7.x86_64 #1 SMP Fri Dec 16 17:29:43 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
LSB Version: :core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID: CentOS
Description: CentOS Linux release 7.9.2009 (Core)
Release: 7.9.2009
Codename: Core

Other Setup

Board = U200
HW_config = alveo_u200_firesim_boom_singlecore_no_nic_l2_llc4mb_ddr3
Workload = spec17-intrate-test-500.json

The FireSim simulation is succesful. The error appears at the post_run_hook phase.

Current Behavior

Running post_run_hook...
Fatal error: local() encountered an error (return code 1) while executing 'cd workloads/spec17-intrate-test-500/ && ../../../target-design/chipyard/software/spec2017/spec2017-workload/handle-results.py -d test -s intrate /home/novo/Work/firesim-1.17.0/deploy/results-workload/2023-07-28--05-42-51-spec17-intrate-test-500/'
================================ Standard error ================================
Traceback (most recent call last):
File "/home/novo/Work/firesim-1.17.0/deploy/workloads/spec17-intrate-test-500/../../../target-design/chipyard/software/spec2017/spec2017-workload/handle-results.py", line 126, in
resDF = handleRate(args.outputPath)
File "/home/novo/Work/firesim-1.17.0/deploy/workloads/spec17-intrate-test-500/../../../target-design/chipyard/software/spec2017/spec2017-workload/handle-results.py", line 101, in handleRate
resDF = resDF.append(pd.read_csv(csvFile))
File "/home/novo/Work/firesim/.conda-env/lib/python3.10/site-packages/pandas/core/generic.py", line 5989, in getattr
return object.getattribute(self, name)
AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

Aborting.
Fatal error.
Traceback (most recent call last):
File "/home/novo/Work/firesim/deploy/firesim", line 530, in
main(args)
File "/home/novo/Work/firesim/deploy/firesim", line 469, in main
t'task'
File "/home/novo/Work/firesim/deploy/firesim", line 258, in runworkload
runtime_conf.run_workload()
File "/home/novo/Work/firesim-1.17.0/deploy/runtools/runtime_config.py", line 912, in run_workload
self.firesim_topology_with_passes.run_workload_passes(use_mock_instances_for_testing)
File "/home/novo/Work/firesim-1.17.0/deploy/runtools/firesim_topology_with_passes.py", line 736, in run_workload_passes
localcap = local("""cd {} && {} {}""".format(self.workload.workload_input_base_dir,
File "/home/novo/Work/firesim/.conda-env/lib/python3.10/site-packages/fabric/operations.py", line 1250, in local
error(message=msg, stdout=out, stderr=err)
File "/home/novo/Work/firesim/.conda-env/lib/python3.10/site-packages/fabric/utils.py", line 357, in error
return func(message)
File "/home/novo/Work/firesim/.conda-env/lib/python3.10/site-packages/fabric/utils.py", line 65, in abort
raise e
SystemExit: 1

Expected Behavior

I could resolve the error by modifying line 101 of handle-results.py. Apparently, the 'DataFrame' object has no attribute 'append.'

Old:
resDF = resDF.append(pd.read_csv(csvFile))

New:
resDF = resDF._append(pd.read_csv(csvFile))

Other Information

No response